bnjbvr/gitlab-to-irc
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Correctly conjugate action verb for merge requests too;

Browse Source
This commit is contained in:
Benjamin Bouvier 2017-09-20 12:41:07 +02:00
parent 3410be5d5c
commit 98d28f8154
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
index.js
View File

@ -69,6 +69,11 @@ if (config.lstu) {
}; };
} }
function conjugatePast(verb) {
// Make action displayable (e.g., open -> opened, close -> closed, merge -> merged).
return verb + (verb.substr(-1) === 'e' ? '' : 'e') + 'd';
}
var handlers = { var handlers = {
push: function(body, say) { push: function(body, say) {
@ -127,8 +132,7 @@ var handlers = {
if (issue.action === 'update') if (issue.action === 'update')
return; return;
// Make action displayable (e.g., open -> opened, close -> closed, merge -> merged). var displayedAction = conjugatePast(issue.action);
var displayedAction = issue.action + (issue.action.substr(-1) === 'e' ? '' : 'e') + 'd';
shortenURL(url, function(shortUrl) { shortenURL(url, function(shortUrl) {
var msg = user + ' ' + displayedAction + ' issue #' + issueNumber + ' ("' + issueTitle + '") on ' + projectName + ' ' + shortUrl; var msg = user + ' ' + displayedAction + ' issue #' + issueNumber + ' ("' + issueTitle + '") on ' + projectName + ' ' + shortUrl;
@ -156,8 +160,10 @@ var handlers = {
return; return;
} }
var displayedAction = conjugatePast(request.action);
shortenURL(url, function(shortUrl) { shortenURL(url, function(shortUrl) {
var msg = user + ' ' + request.action + 'd MR !' + id + ' (' + from + '->' + to + ': ' + title + ') ' + var msg = user + ' ' + displayedAction + ' MR !' + id + ' (' + from + '->' + to + ': ' + title + ') ' +
' on ' + projectName + '; ' + shortUrl; ' on ' + projectName + '; ' + shortUrl;
say(msg); say(msg);
}); });